-
-
Notifications
You must be signed in to change notification settings - Fork 655
Fix upper bounds added for DataFrames 0.11 #12223
Fix upper bounds added for DataFrames 0.11 #12223
Conversation
BioMedQuery/versions/0.1.0/requires
Outdated
@@ -1,4 +1,4 @@ | |||
julia 0.4.1 | |||
julia 0.4.1 0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better to add a fake DataFrames dependency here
It's better to add fake DataFrames dependencies than julia upper bounds, unless you're absolutely sure that each version you're adding a julia upper bound to doesn't load at all on that version. |
OK. I've moved to fake DataFrames dependencies for all releases which supported Julia 0.5. For others, there's little chance they would work on 0.6. |
Have you verified that? Since DataFrames has been around so long, a fake dependency is nearly harmless. |
TBH I don't really feel like changing all these ~100 releases to use a fake DataFrames dependency. I'd better spend my time on something more productive. Anyway in a few weeks we'll have 1.0 and people won't even remember 0.6 has existed. |
Adding a julia upper bound is pretty drastic and causes errors if anyone has that version installed or pinned, so it should really only be done when it's absolutely known to already not work at all, or there's no other less harmful option. These hundreds of packages are going to prevent many people from using the new DataFrames for some time with the release having been done in place like this. |
Possibly useful to anyone dealing with this: |
OK, I've changed all Julia upper bounds into fake DataFrames dependencies. Should be good to go now.
@timholy Cool. I wish I had know the existence of this tool before I made the PR... :-/ |
Note all the comments on that PR, it does not address the issues that made the original PR incomplete. It could automate the text replacement for existing requirements, but doesn't do a completeness check to verify that it will address a compatibility issue without leading to unintended resolution possibilities. |
Yeah, there's a bit of a conundrum here: it's already useful but making it "industrial strength" is a lot of work. I started it as a charity project but don't intend to finish it unless a desperate personal need arises. I still hold out hope that someone more deeply involved in package management will pick it up someday. |
@nalimilan shall we merge this and the other one? Looks good to me. |
The lower bounds should all be 0.0.0, not 0.0.1 |
I've added a commit to fix this. |
Use fake DataFrames dependencies instead of upper bounds on Julia. Use version 0.0.0 rather than 0.0.1.
Same as PR #12220 but for DataFrames. This requires adding a lot of Julia 0.6 upper bounds