-
-
Notifications
You must be signed in to change notification settings - Fork 655
Fix upper bounds added for DataArrays 0.7.0 #12220
Fix upper bounds added for DataArrays 0.7.0 #12220
Conversation
Are you sure none of the versions with julia upper bounds added load at all on that version of Julia? Generally better to add a fake dependency (as long as there's at least one DataArrays version that works for all supported Julia versions of the package version where you add the fake dependency) than prevent installation. |
In this PR, the only one is BioMedQuery. Others are really too old to work on 0.6. I've added a commit to use a fake DataArrays dep. |
TermWin/versions/0.0.10/requires
Outdated
@@ -1,2 +1,2 @@ | |||
Lint | |||
julia 0.3- | |||
julia 0.3- 0.6 0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is effectively not bounded above at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I probably made a mistake with sed
.
Merge? |
DataArrays had an 0.0.0, so the lower bounds shouldn't be 0.0.1 |
Fixed. |
Add fake DataArrays dependency to previous releases of packages that use it. Use 0.0.0 rather than 0.0.1 for lower bound.
@tkelman noted at #12189 that I forgot to add upper bounds to older releases of DataArrays dependencies which did not depend on it yet, which means that the package manager may downgrade these packages. The check was quite tedious, but overall there aren't many problematic situations, since almost all packages either also depended on DataFrames (which itself depended on DataArrays, so adding the dependency is OK) or were very old (so that an upper bounds on Julia 0.6 is fine). The only case where I added an upper bound on Julia 0.6 to a relatively recent package is EasyPhys 0.1.3, but well...
For reference, the command I found to identify packages which depended on DataArrays in some but not all releases:
(By removing the last two commands, you get the list of releases which do not depend on DataArrays. That's only a problem if there are more recent releases which do depend on it.)
This gives: