Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Fix upper bounds added for DataArrays 0.7.0 #12220

Merged
merged 18 commits into from
Dec 6, 2017
Merged

Fix upper bounds added for DataArrays 0.7.0 #12220

merged 18 commits into from
Dec 6, 2017

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Nov 26, 2017

@tkelman noted at #12189 that I forgot to add upper bounds to older releases of DataArrays dependencies which did not depend on it yet, which means that the package manager may downgrade these packages. The check was quite tedious, but overall there aren't many problematic situations, since almost all packages either also depended on DataFrames (which itself depended on DataArrays, so adding the dependency is OK) or were very old (so that an upper bounds on Julia 0.6 is fine). The only case where I added an upper bound on Julia 0.6 to a relatively recent package is EasyPhys 0.1.3, but well...

For reference, the command I found to identify packages which depended on DataArrays in some but not all releases:

grep -Rl DataArrays | sed "s/\/.*$//g" | uniq | xargs grep -RL DataArrays | grep requires | sed "s/\/.*$//g" | uniq

(By removing the last two commands, you get the list of releases which do not depend on DataArrays. That's only a problem if there are more recent releases which do depend on it.)

This gives:

Benchmarks: added DataArrays bounds since it also depended on DataFrames
DataArrays: ...
DataFrames: added julia 0.6 upper bound since only old releases did not depend on DataArrays
Discretizers: only old versions depended on DataArrays, so OK
FactorModels: already has an upper bound on julia 0.6
Feather: added DataArrays bounds since it also depended on DataFrames
Gadfly: added DataArrays bounds since it also depended on DataFrames
GeoIP: added DataArrays bounds since it also depended on DataFrames
GoogleCharts: added DataArrays bounds since it also depended on DataFrames
MarketTechnicals: added DataArrays bounds since it also depended on DataFrames (version 0.0.0 only)
MixedModels:  added DataArrays bounds to  since it also depended on DataFrames (versions 0.3.0 to 0.5.1, since others are OK or have an upper bound on julia 0.6)
NormalizeQuantiles: only older releases depended on DataArrays
RCall: only older releases depended on DataArrays
RDatasets: added DataArrays bounds since it also depended on DataFrames
RobustStats: added DataArrays bounds since it also depended on DataFrames
SALSA: only older releases depended on DataArrays
SQLite: only older releases depended on DataArrays, except one release which has julia 0.4 upper bound
Taro: added DataArrays bounds since it also depended on DataFrames
TermWin: added julia 0.6 upper bound since only old releases did not depend on DataArrays
TimeData: added DataArrays bounds since it also depended on DataFrames (only old releases)
TimeSeries: added DataArrays bounds since it also depended on DataFrames (only old releases) 
EasyPhys: added julia 0.6 upper bound to version 0.1.3 since it was the only release not to depend on DataArrays
LazyQuery: added DataArrays bounds since it also depended on DataFrames

@tkelman
Copy link
Contributor

tkelman commented Nov 26, 2017

Are you sure none of the versions with julia upper bounds added load at all on that version of Julia? Generally better to add a fake dependency (as long as there's at least one DataArrays version that works for all supported Julia versions of the package version where you add the fake dependency) than prevent installation.

@nalimilan
Copy link
Member Author

In this PR, the only one is BioMedQuery. Others are really too old to work on 0.6. I've added a commit to use a fake DataArrays dep.

@@ -1,2 +1,2 @@
Lint
julia 0.3-
julia 0.3- 0.6 0.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is effectively not bounded above at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I probably made a mistake with sed.

@aviks aviks closed this Nov 26, 2017
@aviks aviks reopened this Nov 26, 2017
@nalimilan
Copy link
Member Author

Merge?

@tkelman
Copy link
Contributor

tkelman commented Nov 27, 2017

DataArrays had an 0.0.0, so the lower bounds shouldn't be 0.0.1

@tkelman
Copy link
Contributor

tkelman commented Nov 27, 2017

#12189, #12188, and #12223 also did that incorrectly, the lower bounds shouldn't be excluding a valid version

@nalimilan
Copy link
Member Author

Fixed.

@nalimilan nalimilan merged commit 1aabee7 into JuliaLang:metadata-v2 Dec 6, 2017
@nalimilan nalimilan deleted the nl/DataArrays_0.7.0 branch December 6, 2017 15:45
nkottary pushed a commit to nkottary/METADATA.jl that referenced this pull request Dec 29, 2017
Add fake DataArrays dependency to previous releases of packages that use it. Use 0.0.0 rather than 0.0.1 for lower bound.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants