Add support for Base.display_error over ExceptionStack. #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 78.35% 78.56% +0.20%
==========================================
Files 4 4
Lines 633 639 +6
==========================================
+ Hits 496 502 +6
Misses 137 137
Continue to review full report at Codecov.
|
|
It looks like Julia 1.1 lacks |
Sacha0
force-pushed
the
sv-display-error
branch
from
6502e11 to
8d60f8d
Compare
|
CI appears happy now; review much appreciated :). |
Sacha0
force-pushed
the
sv-display-error
branch
from
8d60f8d to
cc952cc
Compare
|
Rebased over #758. What say you, CI? :) |
Sacha0
force-pushed
the
sv-display-error
branch
2 times, most recently
from
7a0e166 to
1e788d1
Compare
Sacha0
force-pushed
the
sv-display-error
branch
from
1e788d1 to
5709d7e
Compare
|
@c42f, might I trouble you to have a look at this related patch as well? Thanks again! :) |
c42f
approved these changes
Sep 24, 2021
NHDaly
reviewed
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#746 added support for
current_exceptions/ExceptionStack(néecatch_stack), and augmented a few functions with methods that commonly handleExceptionStacks. This pull request extends that to support toBase.display_error, which also commonly handlesExceptionStacks. Best! :)