-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Base.current_exceptions() to older Julia versions #746
Conversation
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 81.71% 81.99% +0.28%
==========================================
Files 4 4
Lines 536 561 +25
==========================================
+ Hits 438 460 +22
- Misses 98 101 +3
Continue to review full report at Codecov.
|
Failing tests on nightly are #745 |
With a README entry and after a rebase, this looks good to me. |
See JuliaLang/julia#29901 This is limited to julia-1.1 and above because earlier versions don't have the necessary runtime library support (Base.catch_stack() etc).
cff5be3
to
29e040b
Compare
I added the readme entry and rebased. Also I've added julia-1.0 compatibility (in that case, the best we can do is just return the current exception as a single-element stack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM superficially, but you probably know better than me whether this does the right thing.
But maybe we should mention the limited functionality on Julia 1.0 in the README?
It should do the right thing to the extent that the right thing can be done at all in julia 1.0 (there were some nasty bugs with exceptions and backtraces going missing completely in julia-1.0 due to task switching. But Compat can't work around that.) I figured it was better to have the API with only approximate runtime compatibility in 1.0, than to not have the API at all — it's a lot easier for users if they can at least rely on the API being present on all versions supported by Compat. |
I don't disagree. Only question: Merge as is or mention the limitation re: Julia 1.0 in the README? |
Yeah, it's worth mentioning the Julia-1.0 limitations in the readme. I did that. |
Alright, there was plenty of time for others to chime in on this, bu no one did, so here we go... |
See JuliaLang/julia#29901
This is limited to julia-1.1 and above because earlier versions don't
have the necessary runtime library support (
Base.catch_stack()
etc).