Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @something and @coalesce #742

Merged
merged 2 commits into from
May 14, 2021
Merged

Add @something and @coalesce #742

merged 2 commits into from
May 14, 2021

Conversation

omus
Copy link
Member

@omus omus commented May 14, 2021

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #742 (f213d30) into master (13757f5) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   75.38%   75.91%   +0.52%     
==========================================
  Files           4        4              
  Lines         455      465      +10     
==========================================
+ Hits          343      353      +10     
  Misses        112      112              
Impacted Files Coverage Δ
src/Compat.jl 75.18% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13757f5...f213d30. Read the comment docs.

@omus
Copy link
Member Author

omus commented May 14, 2021

Just to be safe I'm going to rebase this change once #743 is merged.

@omus omus force-pushed the cv/at-something branch from f213d30 to 02c61f0 Compare May 14, 2021 21:13
@omus omus merged commit 61726a3 into master May 14, 2021
@omus omus deleted the cv/at-something branch May 14, 2021 22:32
bors bot added a commit to JuliaCloud/AWS.jl that referenced this pull request May 27, 2021
371: Use external `@something` r=mattBrzezinski a=omus

Replaces the definition of `@something` with the one [from base](JuliaLang/julia#40729) or [from Compat.jl](JuliaLang/Compat.jl#742).

Co-authored-by: Curtis Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants