Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external @something #371

Merged
merged 1 commit into from
May 27, 2021
Merged

Use external @something #371

merged 1 commit into from
May 27, 2021

Conversation

omus
Copy link
Member

@omus omus commented May 26, 2021

Replaces the definition of @something with the one from base or from Compat.jl.

@omus
Copy link
Member Author

omus commented May 26, 2021

bors try

bors bot added a commit that referenced this pull request May 26, 2021
@bors
Try #371:
1f74216
@bors
Copy link
Contributor

bors bot commented May 26, 2021

try

Build succeeded:

@omus omus requested a review from mattBrzezinski May 27, 2021 18:38
mattBrzezinski
mattBrzezinski approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@mattBrzezinski mattBrzezinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattBrzezinski
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented May 27, 2021

Build succeeded:

@bors bors bot merged commit 7a5fe1a into master May 27, 2021
@bors bors bot deleted the cv/base-at-something branch May 27, 2021 18:45
@mbauman mbauman mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omus @mattBrzezinski