Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add remote demos from other packages #218

Draft
wants to merge 3 commits into
base: source
Choose a base branch
from

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Aug 15, 2021

This is a parallel work to #159 and focuses only on demos.

This setup would grab all the demos from other packages and build a centralized one, for test purposes, I've added two packages:

Currently, this is a playground for JuliaDocs/DemoCards.jl#89 (still WIP), but you can check the previews at https://juliaimages.org/previews/PR218/examples

Current unsolved issues:

  • the assets/covers are not generated correctly
  • section titles might need another name

@johnnychen94
Copy link
Member Author

Yeah it works:

bad_result.png

Eventually, I'd like to make it

{
    "theme": "grid",
    "remote": {
        "transformations": "https://github.com/JuliaImages/ImageTransformations.jl.git:docs/examples"
    }
}

or

{
    "theme": "grid",
    "remote": {
        "transformations": {
            "url": "https://github.com/JuliaImages/ImageTransformations.jl.git",
            "subdir": "docs/examples"
        }
    }
}

so that we don't need to introduce the external git submodule commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant