WIP: add LocalRemoteCard and LocalRemoteSection
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 88.21% 87.20% -1.01%
==========================================
Files 14 15 +1
Lines 823 930 +107
==========================================
+ Hits 726 811 +85
- Misses 97 119 +22
Continue to review full report at Codecov.
|
johnnychen94
changed the title
LocalRemote[Card|Section|Page]LocalRemoteCard and LocalRemoteSection
some other small changes: - validate_order: make sure `order` field is unique - show: remove extra new line for AbstractDemoCard
johnnychen94
force-pushed
the
jc/localremote
branch
from
172157b to
06ce59f
Compare
It becomes nontrivial to fetch enough information if we can't ensure the local remote file exists. This commit makes all remote entries normal direct entries by copying the contents and remove the "remote" from config.json.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards #72
LocalRemotePageis just a normalDemoPageas far as I'm understanding.Todo:
LocalRemoteCardLocalRemoteSectionLocalRemoteCardas a virtual card placeholder will be generated if"remote"is specified in section level:{ "remote": { "julia_card.jl": "../../card/julia/title_1.jl", "markdown_card.md": "../../card/markdown/title_3.md" }, "order": [ "julia_card.jl", "markdown_card.md", "title_2.md" ] }Efforts are paid to support:
LocalRemoteCardand normal demo files, as well asorderLocalRemoteCardcan be either an absolute path or a relative path (wrt theconfig.json)