Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Images is here #577

Merged
merged 38 commits into from
Jan 30, 2017
Merged

The new Images is here #577

merged 38 commits into from
Jan 30, 2017

Conversation

timholy
Copy link
Member

@timholy timholy commented Jan 29, 2017

As discussed in #542. See the documentation at JuliaImages (the documentation will be fully up to date only after this is merged and tagged).

Fixes #73, #124, #187, #267, #319, #368, #375, #367, #386, #447, #449, #451, #471, #539, #542, #545, #553. That should be enough for now 😄.

This interacts with many other packages, and I've realized that many people might have a subset of packages checked out on master and another subset following released versions, so it will be too disruptive to wait a week or so before tagging (as I had indicated at one point). Consequently, I'm tagging as soon as this merges.

It would be great if QuartzImageIO could update fairly soon (JuliaIO/QuartzImageIO.jl#28), since Mac users are going to encounter trouble until that happens. I've given rather a lot of warning about this, hoping to have a PR queued already, but since little has changed since October it looks like we'll just have to figure it out after the fact.

Mostly this relied on changes in other packages. The labels are useful because FactCheck messes up line numbers in reporting.
We may want to reduce to just one of these, but there are differences (RealLike implies the existence of a total order, whereas NumberLike does not). For now this already represents some centralization.
writemime is the exception
That method should not have been defined in the first place
@timholy
Copy link
Member Author

timholy commented Jan 30, 2017

That felt good.

@timholy
Copy link
Member Author

timholy commented Jan 30, 2017

Oh, and there's a new file here that is intended to help with folks with migration; basically a "how do I get around this error message?" FAQ.

@vchuravy
Copy link

That felt good.

Congratulations! 🎉

@tkelman
Copy link
Collaborator

tkelman commented Jan 31, 2017

Worth adding bounds for ImageView and ImagineFormat?

@timholy
Copy link
Member Author

timholy commented Jan 31, 2017

ImageView is already updated. (Part of my mistaken direct-push to METADATA.jl). Don't worry about ImagineFormat, there's already a branch that folks can use. Just mulling over whether I should make more changes first.

@tkelman
Copy link
Collaborator

tkelman commented Jan 31, 2017

It's already updated if people are using the latest version of ImageView, but if they try to use any older versions of it against the latest Images it isn't going to work.

@timholy
Copy link
Member Author

timholy commented Jan 31, 2017

Then sure, it would be fine. Thanks again!

@tkelman
Copy link
Collaborator

tkelman commented Jan 31, 2017

Oh, hah, you already did -
https://github.com/JuliaLang/METADATA.jl/tree/metadata-v2/ImageView/versions
https://github.com/JuliaLang/METADATA.jl/tree/metadata-v2/ImagineFormat/versions

the failures were just because there wasn't a new tagged version to test from yet.

@rsrock
Copy link
Collaborator

rsrock commented Jan 31, 2017

Quick question here. Is that how you add an upper bound to already tagged and published versions, by editing the REQUIRES files in METADATA? I'll have to do the same thing soon for QuartzImageIO.

@tkelman
Copy link
Collaborator

tkelman commented Jan 31, 2017

Yep. I can help you through it if you need any help.

@montyvesselinov
Copy link

A simple load of a PNG file fails:

img = Images.load("any_test.png")

Errors encountered while loading "/Users/monty/test.png".
All errors:
   ErrorException("\"colorspace\" property is ignored, now color is encoded only by the element type.\nSee `colorview` to represent a numeric array as a color array.")
   FileIO.NotInstalledError(:ImageMagick,"")
Fatal error:
ERROR: "colorspace" property is ignored, now color is encoded only by the element type.
See `colorview` to represent a numeric array as a color array.
 in checked_import(::Symbol) at /Users/monty/.julia/v0.5/FileIO/src/loadsave.jl:12
 in #load#17(::Array{Any,1}, ::Function, ::FileIO.File{FileIO.DataFormat{:PNG}}) at /Users/monty/.julia/v0.5/FileIO/src/loadsave.jl:83
 in load(::FileIO.File{FileIO.DataFormat{:PNG}}) at /Users/monty/.julia/v0.5/FileIO/src/loadsave.jl:75
 in #load#13(::Array{Any,1}, ::Function, ::String) at /Users/monty/.julia/v0.5/FileIO/src/loadsave.jl:45
 in load(::String) at /Users/monty/.julia/v0.5/FileIO/src/loadsave.jl:45

@timholy
Copy link
Member Author

timholy commented Feb 2, 2017

If you're on mac, for now first say using ImageMagick. (Thanks to @rsrock, QuartzImageIO is almost fixed, JuliaIO/QuartzImageIO.jl#29.)

@rsrock
Copy link
Collaborator

rsrock commented Feb 2, 2017

That's right. I'm taking the chance to clean up a few more bits, but hopefully the fixed QuartzImageIO will land today.

@montyvesselinov
Copy link

Pkg.add("ImageMagick")

resolved all the issues. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants