Guidance on images-next

[timholy]

If anyone is interested in creating an images-next branch, the best model to follow would be my commit to ImageMagick: JuliaIO/ImageMagick.jl@348e9ac. From a brief scan of the code in this repo, aside from updating the tests it seems like it could be as simple as:

• returning the plain array and skipping the Dict creation, just returning buf directly.
• some small fixes for writemime

[tlnagy]

@timholy It looks like there are more problems then just that:

julia> using TestImages

julia> img = testimage("mandrill")
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
in read_and_release_imgsrc at
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
in read_and_release_imgsrc at /Users/tamasnagy/.julia/v0.5/QuartzImageIO/src/QuartzImageIO.jl
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
in read_and_release_imgsrc at /Users/tamasnagy/.julia/v0.5/QuartzImageIO/src/QuartzImageIO.jl
WARNING: ImageMetadata.Image is deprecated, use ImageMetadata.ImageMeta instead.
  likely near no file:0
in read_and_release_imgsrc at /Users/tamasnagy/.julia/v0.5/QuartzImageIO/src/QuartzImageIO.jl
Errors encountered while loading "/Users/tamasnagy/.julia/v0.5/TestImages/images/mandrill.tiff".
All errors:
   ErrorException("\"colorspace\" property is ignored, now color is encoded only by the element type.\nSee `colorview` to represent a numeric array as a color array.")
   FileIO.NotInstalledError(:ImageMagick,"")
Fatal error:
ERROR: "colorspace" property is ignored, now color is encoded only by the element type.
See `colorview` to represent a numeric array as a color array.
 in checked_import(::Symbol) at /Users/tamasnagy/.julia/v0.5/FileIO/src/loadsave.jl:12
 in #load#17(::Array{Any,1}, ::Function, ::FileIO.File{FileIO.DataFormat{:TIFF}}) at /Users/tamasnagy/.julia/v0.5/FileIO/src/loadsave.jl:81
 in load(::FileIO.File{FileIO.DataFormat{:TIFF}}) at /Users/tamasnagy/.julia/v0.5/FileIO/src/loadsave.jl:73
 in #load#13(::Array{Any,1}, ::Function, ::String) at /Users/tamasnagy/.julia/v0.5/FileIO/src/loadsave.jl:45
 in testimage(::String) at /Users/tamasnagy/.julia/v0.5/TestImages/src/TestImages.jl:75

[timholy]

Looks like something must still be calling Image. Search for it?

[tlnagy]

likely near no file:0

Any idea on why the error is so useless?

[timholy]

Longstanding problem, unfortunately. JuliaLang/julia#16967 is relevant.

[rsrock]

As noted over on Images, I have something in the works here. Loading is fixed, and saving is working for at least one array type (the "autumn_leaves" test). I'd like to work on something more general for saving-- off to study the ImageMagick code!

[timholy]

Great! https://github.com/JuliaImages/Images.jl/blob/master/upgrading_tips.md may be handy, and of course feel free to contribute any tips that you think are "re-usable." I expect a lot of people have private analysis code that may be affected by the recent changes 😦, so a collection of "ways to cope" might be helpful.

[rsrock]

Closed by 4c19585