-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApproximatePeriodicKernel #98
Conversation
Will be splitted to treat the |
Work in progress:
|
This will need some fixes from #100 but ready otherwise |
Another issue is with the argument for the PeriodicKernel, it is bounded but we do not do any transformation. This is messing up computations when using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean. Maybe a few tests comparing a normal GP to a temporal GP with ApproxPeriodixKernel
would add some safety, e.g. comparing the logpdf
output and maybe posterior mean and variance.
This is already the case! If you look at the lti_sde tests, the prior is compared against a "naive" GP. |
Co-authored-by: Simone Carlo Surace <[email protected]>
Indeed, thanks! |
Pull Request Test Coverage Report for Build 4817610971Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
@willtebbutt this is fully ready for a review. |
@willtebbutt are there any blockers for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no blockers really. I'm happy for this to be merged
This is an attempt at #61
Left todo:
ApproxPeriodicKernel