Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradient for KernelSum and KernelProduct fail #95

Closed
Tracked by #96
theogf opened this issue Mar 21, 2023 · 3 comments
Closed
Tracked by #96

Gradient for KernelSum and KernelProduct fail #95

theogf opened this issue Mar 21, 2023 · 3 comments
Labels
testing

Comments

@theogf
Copy link
Member

theogf commented Mar 21, 2023

The tests containing a sum of kernels have been commented out in test/models/lti_sde.jl, they should be added back and solved
@theogf theogf mentioned this issue Mar 21, 2023
Closed
3 tasks
@theogf
Copy link
Member Author

theogf commented Apr 4, 2023

Issues seems to stem from different Tangent types at the leaf level. It looks really hard to debug...

@theogf theogf added the testing label Apr 4, 2023
@theogf theogf changed the title Add tests for sum of kernels back Gradient for KernelSum and KernelProduct fail Apr 27, 2023
@theogf
Copy link
Member Author

theogf commented Apr 27, 2023

[UPDATE:]
So by using the to_vec approach with #98, now gradients are comparable but are not equal, they are left as broken for now. There is highly probably an error there somewhere.

@willtebbutt
Copy link
Member

I can't find the example that you're talking about, so I'm going to close this (there aren't any failing examples left now that we're using Mooncake). Please feel free to reopen if you think I've missed something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willtebbutt @theogf