Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type instability in closure emitted by flatten for Vector #61

Merged
merged 6 commits into from
Jun 15, 2023
Merged

Fix type instability in closure emitted by flatten for Vector #61

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f0bb09
Fix type instability in closure emitted by `flatten` for `Vector`
simsurace Apr 27, 2023
6656ba8
Shorten function definition
simsurace Apr 27, 2023
c171764
Add unit test (broken on master)
Apr 27, 2023
bd7e91f
Remove whitespace
simsurace Apr 27, 2023
c87113c
Remove whitespace
simsurace Apr 27, 2023
15a8507
Bump version
simsurace Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/flatten.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ function flatten(::Type{T}, x::R) where {T<:Real,R<:Real}
return v, unflatten_to_Real
end

flatten(::Type{T}, x::Vector{R}) where {T<:Real,R<:Real} = (Vector{T}(x), Vector{R})
function flatten(::Type{T}, x::Vector{R}) where {T<:Real,R<:Real}
function unflatten_to_Vector(v::Vector{T})
return convert(Vector{R}, v)
end
simsurace marked this conversation as resolved.
Show resolved Hide resolved
return Vector{T}(x), unflatten_to_Vector
end

function _flatten_vector_integer(::Type{T}, x::AbstractVector{<:Integer}) where {T<:Real}
unflatten_to_Vector_Integer(x_vec) = x
Expand Down