Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type instability in closure emitted by flatten for Vector #61

Merged
merged 6 commits into from
Jun 15, 2023

Conversation

simsurace
Copy link
Member

Fixes #60

@simsurace simsurace requested a review from willtebbutt April 27, 2023 12:14
src/flatten.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (e16589b) 97.29% compared to head (15a8507) 97.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   97.29%   97.32%   +0.02%     
==========================================
  Files           8        8              
  Lines         222      224       +2     
==========================================
+ Hits          216      218       +2     
  Misses          6        6              
Impacted Files Coverage Δ
src/flatten.jl 98.33% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/flatten.jl Outdated Show resolved Hide resolved
test/flatten.jl Outdated Show resolved Hide resolved
simsurace and others added 2 commits April 27, 2023 16:11
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
test/flatten.jl Outdated Show resolved Hide resolved
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Please feel free to merge once you've bumped the patch version. Thanks for fixing this

@simsurace
Copy link
Member Author

Failures on Julia 1.5 are unrelated, see #62

@simsurace simsurace merged commit 7cf6523 into master Jun 15, 2023
@simsurace simsurace deleted the bugfix/flatten-vector branch June 15, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why constructor instead of identity
2 participants