Use const Refs to store gl function pointers instead of mutable structs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks more reasonable. Was there a specific use case to make this change? |
|
I think this came up when I profiled my code and saw more allocations than I expected |
|
Well, that sounds like a pretty important change then :-D |
|
Sounds reasonable. In any case ref make more sense for the code here. I'll merge sans objections. |
musm
pushed a commit
to musm/ModernGL.jl
that referenced
this pull request
Apr 28, 2021
…ts (JuliaGL#62) Co-authored-by: Johannes Thraen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.