Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace random ElasticNet problem in tests with fixed one #38

Merged
merged 1 commit into from
May 3, 2020
Merged

Replace random ElasticNet problem in tests with fixed one #38

merged 1 commit into from
May 3, 2020

Conversation

lostella
Copy link
Member

@lostella lostella commented May 2, 2020

Fixes #37

@lostella lostella requested a review from nantonel May 2, 2020 20:03
@lostella lostella mentioned this pull request May 2, 2020
Closed
nantonel
nantonel approved these changes May 3, 2020
View reviewed changes
Copy link
Collaborator

@nantonel nantonel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@nantonel nantonel merged commit 2a6dc34 into JuliaFirstOrder:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nantonel nantonel nantonel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests on number of iterations are sensitive to randn
2 participants
@lostella @nantonel