-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests on number of iterations are sensitive to randn #37
Comments
@lostella I remember we decided to relax the tests on the number of iterations (I couldn't find the issue though). Looks like they were not relaxed enough? The order look very similar, so it is definitively that:
I wonder if these tests could be replaced by something more robust... |
@nantonel I think at this point it would be great to replace these tests with some fixed problem, instead of randomly generated... |
I see that most calls to That should avoid pasting numbers like in the LBFGS tests unless random generators are changed which I don't think happen very often. |
A PkgEval run for a PR which changes the generated numbers for
randn!
indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master). Apologies if this is a false positive.cf. https://github.com/JuliaCI/NanosoldierReports/blob/7de24e455342298cbef56826b5827f0d7640d2c1/pkgeval/by_hash/b89e35c_vs_098ef24/logs/ProximalAlgorithms/1.5.0-DEV-71a4a114c2.log
The text was updated successfully, but these errors were encountered: