Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bulma.sass to v0.9.4 and darkly.scss to v0.8.1 #2071

Merged
merged 8 commits into from
Mar 17, 2023

Conversation

inkydragon
Copy link
Contributor

@inkydragon inkydragon commented Mar 14, 2023

  • bulma.sass from v0.7.5 to v0.9.4
  • darkly.scss to v0.8.1
  • update compiled css

@mortenpi
Copy link
Member

Mentioning just in case -- the CSS can be updated with DocumenterTools: #2065 (comment)

@mortenpi
Copy link
Member

Actually, the easiest way is:

$ julia docs/instantiate.jl
$ julia --project=docs/
julia> using DocumenterTools
julia> DocumenterTools.Themes.compile_native_themes()

However, I am hitting

ERROR: The target selector was not found.
Use "@extend .is-size-7 !optional" to avoid this error.
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] compile_file(filename::String; input_path::String, source_map_file::Nothing, kwargs::Base.Pairs{Symbol, String, Tuple{Symbol, Symbol}, NamedTuple{(:output_path, :include_path), Tuple{String, String}}})
   @ Sass ~/.julia/packages/Sass/K4Tzw/src/julian_api.jl:69
 [3] #compile_file#2
   @ ~/.julia/packages/Sass/K4Tzw/src/julian_api.jl:85 [inlined]
 [4] compile(src::String, dst::String)
   @ DocumenterTools.Themes ~/juliadocs/Documenter/docs/dev/DocumenterTools/src/Themes.jl:50
 [5] compile_native_theme(name::String; dst::Nothing)
   @ DocumenterTools.Themes ~/juliadocs/Documenter/docs/dev/DocumenterTools/src/Themes.jl:64
 [6] compile_native_theme
   @ ~/juliadocs/Documenter/docs/dev/DocumenterTools/src/Themes.jl:60 [inlined]
 [7] compile_native_themes()
   @ DocumenterTools.Themes ~/juliadocs/Documenter/docs/dev/DocumenterTools/src/Themes.jl:70
 [8] top-level scope
   @ REPL[3]:1

when I tried it on this branch (also seen on CI).

@inkydragon inkydragon marked this pull request as ready for review March 15, 2023 06:35
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now. Nothing left on your end either @inkydragon, right?

@inkydragon
Copy link
Contributor Author

Nothing left on your end either, right?

yes. I think this pr is ready to merge

@mortenpi mortenpi merged commit 579d478 into JuliaDocs:master Mar 17, 2023
@mortenpi
Copy link
Member

Thanks a lot @inkydragon for all these PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants