Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding padding to menu's element on-hover #2065

Closed
wants to merge 20 commits into from

Conversation

Hetarth02
Copy link
Contributor

This PR aims to close Issue #1899.

@Hetarth02
Copy link
Contributor Author

Hetarth02 commented Mar 12, 2023

@mortenpi @fredrikekre I don't know why it is showing 17 commits?

I have my fork synced with the master branch. So, to make things clear I have only made changes to one scss file which can been seen in the Files changed menu.

@mortenpi
Copy link
Member

Let's discuss how we want to change this in #1899.


You also need to update the CSS files. I don't think we have the process documented anywhere, but you can use DocumenterTools for that. I usually would do something like:

pkg> activate --temp
# Assuming you're in Documenter/, this will add your Documenter dev checkout as a dev. dependency:
pkg> dev .
# You need a special DocumenterTools tag (because the standard versions are not compatible with 0.28):
pkg> add DocumenterTools#documenter-v0.1.14+0.28.0-DEV
julia> using DocumenterTools
julia> DocumenterTools.Themes.compile_native_themes()

I have my fork synced with the master branch.

You have extra commits on your master branch though, which is why they show here. The general practice is to create a new branch from the current master for each PR you want to open. That way you don't run into this. It's fine for this PR though -- we'll squash merge the PR anyway, so the intermediate commits won't affect anything.

Hetarth02 added a commit to Hetarth02/Documenter.jl that referenced this pull request Mar 18, 2023
@Hetarth02
Copy link
Contributor Author

You also need to update the CSS files. I don't think we have the process documented anywhere, but you can use DocumenterTools for that. I usually would do something like:

It would also be helpful to add some documentation regarding this. Do we have something lilke a CONTRIBUTING.md?

@mortenpi
Copy link
Member

It would also be helpful to add some documentation regarding this. Do we have something lilke a CONTRIBUTING.md?

We have this: https://documenter.juliadocs.org/stable/contributing/

@Hetarth02
Copy link
Contributor Author

I am closing this PR for the time being. I will make new PR/reopen this PR later.

@Hetarth02 Hetarth02 closed this May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants