-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding padding to menu's element on-hover #2065
Conversation
- Added .vscode to .gitignore
- Changed placeholder to indicate the shortcut use - Added the change in `CHANGELOG.md` - Made the suggested edits in `.gitignore`
- Changed placeholder to indicate the shortcut use - Added the change in `CHANGELOG.md` - Made the suggested edits in `.gitignore`
Merge branch 'JuliaDocs:master' into development
- Adding padding to menu's element on-hover
@mortenpi @fredrikekre I don't know why it is showing 17 commits? I have my fork synced with the |
Let's discuss how we want to change this in #1899. You also need to update the CSS files. I don't think we have the process documented anywhere, but you can use DocumenterTools for that. I usually would do something like:
You have extra commits on your master branch though, which is why they show here. The general practice is to create a new branch from the current master for each PR you want to open. That way you don't run into this. It's fine for this PR though -- we'll squash merge the PR anyway, so the intermediate commits won't affect anything. |
It would also be helpful to add some documentation regarding this. Do we have something lilke a |
We have this: https://documenter.juliadocs.org/stable/contributing/ |
I am closing this PR for the time being. I will make new PR/reopen this PR later. |
This PR aims to close Issue #1899.