Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/improve GitHub actions YAML setting example #1224

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Simplify/improve GitHub actions YAML setting example #1224

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2267180
Simplify workflow YAML; no need for strategy
tkf Jan 7, 2020
4b7769e
Use actions/checkout v2
tkf Jan 7, 2020
fc7801e
Use push_preview-compatible setup
tkf Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions docs/src/man/hosting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,21 +171,21 @@ workflow configuration file:
```yaml
name: Documentation

on: [push]
on:
push:
branches:
- master
tags: '*'
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:
pull_request: # only needed for preview builds (push_preview=true in deploydocs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this also required for running documenter in PRs from forks? (My post in the OP was a bit misleading.)

I guess people familiar with Travis would find this setup natural.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right.


jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
julia-version: [1.2.0]
julia-arch: [x86]
os: [ubuntu-latest]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1.0.0
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@latest
with:
version: ${{ matrix.julia-version }}
version: 1.3
- name: Install dependencies
run: julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'
- name: Build and deploy
Expand Down