Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/improve GitHub actions YAML setting example #1224

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Jan 7, 2020

This PR contains three independent patches:

@fredrikekre
Copy link
Member

Thanks. I believe the matrix strategy was the only working one back in GitHub actions beta when I first tried this.

branches:
- master
tags: '*'
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:
pull_request: # only needed for preview builds (push_preview=true in deploydocs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this also required for running documenter in PRs from forks? (My post in the OP was a bit misleading.)

I guess people familiar with Travis would find this setup natural.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right.

@fredrikekre fredrikekre merged commit 035bfdd into JuliaDocs:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants