Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve inference in LinearAlgebra/symmetric #371

Merged
merged 3 commits into from
Feb 13, 2021
Merged

Conversation

simeonschaub
Copy link
Member

should fix #356

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Feb 13, 2021
@simeonschaub
Copy link
Member Author

The remaining two failures seem to be Julia bugs (ref JuliaLang/julia#39641). Would be good to keep an eye on whether this always affects the same platforms and report that back.

@codecov-io
Copy link

codecov-io commented Feb 13, 2021

Codecov Report

Merging #371 (fb311af) into master (adcaa91) will decrease coverage by 0.05%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   97.78%   97.72%   -0.06%     
==========================================
  Files          19       19              
  Lines        1487     1495       +8     
==========================================
+ Hits         1454     1461       +7     
- Misses         33       34       +1     
Impacted Files Coverage Δ
src/rulesets/LinearAlgebra/symmetric.jl 98.32% <96.15%> (-0.38%) ⬇️
src/rulesets/LinearAlgebra/factorization.jl 97.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcaa91...fb311af. Read the comment docs.

@github-actions github-actions bot removed the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Feb 13, 2021
@simeonschaub simeonschaub merged commit 5b13ffb into master Feb 13, 2021
@simeonschaub simeonschaub deleted the sds/fix_356 branch February 13, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

at-infererred failures in LinAlg/symmetric tests on Julia nightly
3 participants