add comment, bump patch version

JuliaDiff · Feb 13, 2021 · fb311af · fb311af
1 parent a354d47
commit fb311af
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ChainRules"
 uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
-version = "0.7.51"
+version = "0.7.52"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/test/rulesets/LinearAlgebra/symmetric.jl b/test/rulesets/LinearAlgebra/symmetric.jl
@@ -24,9 +24,10 @@
             ∂x = randn(T, N, N)
             ΔΩ = randn(T, N, N)
             @testset "back(::$MT)" for MT in (Matrix, LowerTriangular, UpperTriangular)
-                _ΔΩ = MT(ΔΩ)
                 rrule_test(
-                    SymHerm, _ΔΩ, (x, ∂x), (uplo, nothing);
+                    SymHerm, MT(ΔΩ), (x, ∂x), (uplo, nothing);
+                    # type stability here critically relies on uplo being constant propagated,
+                    # so we need to test this more carefully below
                     check_inferred=false,
                 )
                 if check_inferred