-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Adjoint and Transpose stuff #324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 18 18
Lines 1011 1011
=======================================
Hits 987 987
Misses 24 24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks right. It looks like this is causing some relevant integration errors with Zygote. Once those are fixed (or if turns out to be a Zygote bug), feel free to bump the version number and merge.
This PR pretty much brings us up to feature-parity with Zygote on the rules for
Adjoint
andTranspose
.TODO:
Composite
s in the reverse-passMakeparent
return aComposite
, rather than the transposition ofȳ
, sinceȳ
might itself be e.g. aComposite
.Testparent
.edit: the second and third points weren't achievable in this PR because our testing infrastructure isn't up to scratch at the minute. Opened this issue regarding the problem.