Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Adjoint and Transpose stuff #324

Merged
merged 9 commits into from
Dec 10, 2020
Merged

Some Adjoint and Transpose stuff #324

merged 9 commits into from
Dec 10, 2020

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Dec 6, 2020

This PR pretty much brings us up to feature-parity with Zygote on the rules for Adjoint and Transpose.

TODO:

  • Enable the use of Composites in the reverse-pass
  • Make the various transpose-like functions play nicely with complex numbers.
  • Make parent return a Composite, rather than the transposition of , since might itself be e.g. a Composite.
  • Test parent.

edit: the second and third points weren't achievable in this PR because our testing infrastructure isn't up to scratch at the minute. Opened this issue regarding the problem.

@codecov-io
Copy link

codecov-io commented Dec 6, 2020

Codecov Report

Merging #324 (17b1350) into master (22eddb4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          18       18           
  Lines        1011     1011           
=======================================
  Hits          987      987           
  Misses         24       24           
Impacted Files Coverage Δ
src/rulesets/LinearAlgebra/structured.jl 98.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22eddb4...17b1350. Read the comment docs.

@willtebbutt willtebbutt requested a review from sethaxen December 6, 2020 17:27
@willtebbutt willtebbutt changed the title WIP: Some Adjoint and Transpose stuff Some Adjoint and Transpose stuff Dec 6, 2020
Copy link
Member

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks right. It looks like this is causing some relevant integration errors with Zygote. Once those are fixed (or if turns out to be a Zygote bug), feel free to bump the version number and merge.

@willtebbutt willtebbutt merged commit abfe271 into master Dec 10, 2020
@willtebbutt willtebbutt deleted the wct/transpose-adjoint branch December 10, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants