Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it merely a warning for the precompile workload to fail #562

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Apr 8, 2024

Cthulhu breaks easily on nightly, but not everyone uses all Cthulhu features.
So making it only a warning while we fix things may be useful.
In particular, right now Cthulu is broken on 1.11-alpha2, due to #343 though it is fixed at the head of the release-1.11 branch.

This in turn breaks Diffractor which has some Cthulhu integrations (reasonable) and also reuses some Cthulhu internals (not so reasonable).
But which actually works fine, its just #343

cf JuliaLang/PrecompileTools.jl#21

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (aecb743) to head (747b279).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #562   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9       9           
  Lines        1545    1545           
======================================
  Misses       1545    1545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviatesk
Copy link
Member

aviatesk commented Apr 8, 2024

I'm in favor of this change, but still have a question: #343 is an issue that was fixed on the Cthulhu-side a while back. Why is it still leading to errors in the release-1.11 Julia?

@oxinabox
Copy link
Contributor Author

oxinabox commented Apr 8, 2024

I assume because a new alpha hasn't been cut since it was fixed?
I haven't actually tested the head of release-11, just alpha2 which is in juliaup

@aviatesk
Copy link
Member

aviatesk commented Apr 8, 2024

Did you get the same error as #342?
I built release-v1.11 Julia manually but I couldn't reproduce it on macOS on the latest Cthulhu master.

@oxinabox
Copy link
Contributor Author

oxinabox commented Apr 8, 2024

oh, now that i look closer no i didn't.
I got a similar but slightly different error.

I will open an issue

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change itself looks fine. Although this doesn't help us use Cthulhu if its precompilation segfaults.

@Keno Keno merged commit 108391a into JuliaDebug:master Apr 9, 2024
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants