Close pipe during precompilation #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
- Coverage 40.05% 32.65% -7.40%
==========================================
Files 10 10
Lines 1106 1084 -22
==========================================
- Hits 443 354 -89
- Misses 663 730 +67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Failures on nightly seem independent of this PR. |
|
The error here is possibly a more sinister one, that a lack of a reader means this code probably does not run to completion. Closing the Pipe merely destroys the error channel too for the REPL |
timholy
added a commit
that referenced
this pull request
Jan 22, 2023
This switches to SnoopPrecompile and uses more careful handling of pipes to ensure tasks run to completion (see comment in #343).
timholy
added a commit
that referenced
this pull request
Feb 3, 2023
This switches to SnoopPrecompile and uses more careful handling of pipes to ensure tasks run to completion (see comment in #343). Co-authored-by: Jameson Nash <[email protected]>
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342