Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderedDict for dictrowtable #277

Merged
merged 4 commits into from
Mar 10, 2022

Conversation

mathieu17g
Copy link
Contributor

Fixes #274

OrderedDict for dictrowtable

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #277 (d8a4cbe) into main (994fc7b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files           7        7           
  Lines         642      642           
=======================================
  Hits          609      609           
  Misses         33       33           
Impacted Files Coverage Δ
src/dicts.jl 93.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994fc7b...d8a4cbe. Read the comment docs.

@bkamins
Copy link
Member

bkamins commented Mar 9, 2022

Also docstrings for dictcoltable and dictrowtable require fixing.

@mathieu17g
Copy link
Contributor Author

Oups sorry, I was a bit sloppy...

@mathieu17g
Copy link
Contributor Author

Independently of this PR, something is going wrong with julia nightly on size(::GenericColumn{Int64}) not implemented on GenericColumn test helper structure

@mathieu17g
Copy link
Contributor Author

Nightly build seems to have regressions (seen on other package CI). I have reverted to test introduced in commit 9b91dff

PR should be ready for merge

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mathieu17g; I also pushed a fix for the nightly test failure, so I'll run the CI here again just to be careful.

@quinnj quinnj merged commit 138c5be into JuliaData:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Tables.dictrowtable use OrderedDict
3 participants