-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrderedDict
for dictrowtable
#277
OrderedDict
for dictrowtable
#277
Conversation
Codecov Report
@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 7 7
Lines 642 642
=======================================
Hits 609 609
Misses 33 33
Continue to review full report at Codecov.
|
Also docstrings for |
Oups sorry, I was a bit sloppy... |
Independently of this PR, something is going wrong with julia nightly on |
Nightly build seems to have regressions (seen on other package CI). I have reverted to test introduced in commit 9b91dff PR should be ready for merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mathieu17g; I also pushed a fix for the nightly test failure, so I'll run the CI here again just to be careful.
Fixes #274
OrderedDict
fordictrowtable