Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tables.dictrowtable use OrderedDict #274

Closed
bkamins opened this issue Feb 20, 2022 · 3 comments · Fixed by #277
Closed

Make Tables.dictrowtable use OrderedDict #274

bkamins opened this issue Feb 20, 2022 · 3 comments · Fixed by #277

Comments

@bkamins
Copy link
Member

bkamins commented Feb 20, 2022

It is debatable, but maybe it is better for Tables.dictrowtable to preserve the order of appearance of columns in the input by switching it to use OrderedDict internally?
@bkamins bkamins mentioned this issue Feb 20, 2022
Open
This was referenced Feb 23, 2022
Merged
Open
@quinnj
Copy link
Member

quinnj commented Mar 6, 2022

I agree this would be more consistent now that we use OrderedDict for dictcolumntable; perhaps we can request @mathieu17g to make a PR?

@bkamins
Copy link
Member Author

bkamins commented Mar 6, 2022

Ah - indeed.

@mathieu17g - in #275 two things are missed:

  • you updated dictcolumntable but also dictrowtable should be likewise updated
  • the docstring of dictcolumntable should be fixed after your PR (as it mentions Dict incorrectly now)

would you be willing to make this PR?

@mathieu17g
Copy link
Contributor

Yes I will look into it.

@mathieu17g mathieu17g mentioned this issue Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OrderedDict for dictrowtable mathieu17g/Tables.jl
3 participants
@quinnj @bkamins @mathieu17g