Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type assertion in _filter_helper #3155

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Fix type assertion in _filter_helper #3155

merged 2 commits into from
Sep 19, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 16, 2022

Fixes #3154

@bkamins bkamins mentioned this pull request Sep 16, 2022
Closed
@bkamins bkamins requested a review from nalimilan September 16, 2022 07:49
@bkamins bkamins added the bug label Sep 16, 2022
@bkamins bkamins added this to the 1.4 milestone Sep 16, 2022
@nalimilan
Copy link
Member

This would be worth releasing/backporting before dropping Julia 1.0 support?

@bkamins
Copy link
Member Author

bkamins commented Sep 19, 2022

For older versions the JuliaData/SentinelArrays.jl#75 PR should also fix it. But I will make a backport as you propose.

@bkamins bkamins merged commit b1c990c into main Sep 19, 2022
@bkamins bkamins deleted the bkamins-patch-1 branch September 19, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

CSV.read returned DataFrame is different?
2 participants
@bkamins @nalimilan