Fix type assertion in _filter_helper (#3155)

JuliaData · Sep 19, 2022 · b1c990c · b1c990c
1 parent 4b40aba
commit b1c990c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -66,6 +66,8 @@
   ([#3081](https://github.com/JuliaData/DataFrames.jl/pull/3081))
 * Make `subset` preserves group ordering when `ungroup=false` like `subset!` already does
   ([#3094](https://github.com/JuliaData/DataFrames.jl/pull/3094))
+* Fix overly restrictive type assertion in `filter` and `filter!`
+  ([#3155](https://github.com/JuliaData/DataFrames.jl/pull/3155))
 
 ## Performance
 

diff --git a/src/abstractdataframe/abstractdataframe.jl b/src/abstractdataframe/abstractdataframe.jl
@@ -1141,7 +1141,7 @@ end
     return view ? Base.view(df, rowidxs, :) : df[rowidxs, :]
 end
 
-_filter_helper(f, cols...)::BitVector = ((x...) -> f(x...)::Bool).(cols...)
+_filter_helper(f, cols...)::AbstractVector{Bool} = ((x...) -> f(x...)::Bool).(cols...)
 
 @inline function Base.filter((cols, f)::Pair{AsTable}, df::AbstractDataFrame;
                              view::Bool=false)
@@ -1155,7 +1155,7 @@ _filter_helper(f, cols...)::BitVector = ((x...) -> f(x...)::Bool).(cols...)
     return view ? Base.view(df, rowidxs, :) : df[rowidxs, :]
 end
 
-_filter_helper_astable(f, nti::Tables.NamedTupleIterator)::BitVector = (x -> f(x)::Bool).(nti)
+_filter_helper_astable(f, nti::Tables.NamedTupleIterator)::AbstractVector{Bool} = (x -> f(x)::Bool).(nti)
 
 """
     filter!(fun, df::AbstractDataFrame)