Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of Downloads.jl having threading issues #594

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Remove mention of Downloads.jl having threading issues #594

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc64593
Remove mention of Downloads.jl having threading issues
arnaudh Dec 13, 2022
0cca0d6
Merge branch 'master' into patch-1
mattBrzezinski Mar 13, 2023
3a724ce
Merge branch 'master' into patch-1
mattBrzezinski Mar 21, 2023
3c84b3e
Update src/utilities/downloads_backend.jl
mattBrzezinski Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/utilities/downloads_backend.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ which is the `Downloads.Downloader` to use. If set to `nothing`, the default,
then a global downloader object will be used.

Downloads.jl tends to perform better under concurrent operation than HTTP.jl,
particularly with `@async` / `asyncmap`. As of March 2022, threading (e.g. `@spawn` or `@threads`) with Downloads.jl is broken on all releases of Julia ([Downloads.jl#110](https://github.com/JuliaLang/Downloads.jl/issues/110)), and there are still reported issues on the upcoming
1.7.3 and 1.8 releases ([Downloads.jl#182](https://github.com/JuliaLang/Downloads.jl/issues/182])).
particularly with `@async` / `asyncmap`. Note that threading (e.g. `@spawn` or `@threads`) with Downloads.jl is broken on Julia releases prior to 1.8 (https://github.com/JuliaLang/Downloads.jl/issues/182#issuecomment-1069269944).
"""
struct DownloadsBackend <: AWS.AbstractBackend
downloader::Union{Nothing,Downloads.Downloader}
Expand Down