Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of Downloads.jl having threading issues #594

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

arnaudh
Copy link
Contributor

@arnaudh arnaudh commented Dec 13, 2022

The issues mentioned in the comment are closed, and seem fixed based on a cursory look at the comments there:

Is it fair to say Downloads.jl doesn't have threading issues anymore? I have zero knowledge around this, just trying to understand how safe it is to use this backend for our use case (at Invenia) where threading might be used.

The mentioned issues are closed:
- JuliaLang/Downloads.jl#110 (closed in Nov 2021
- JuliaLang/Downloads.jl#182 (closed in Apr 2022)
@mattBrzezinski
Copy link
Member

@ericphanson commented this 9 months ago in this commit.

I think we should just need to test and confirm the usages here to make sure it works as intended?

@ericphanson
Copy link
Member

I think HTTP.jl v1 may also have fixed a lot of its concurrency issues. I myself haven't tried any threading experiments w/ HTTP.jl v1 or Downloads.jl on Julia 1.8 yet though, and haven't seen any discussion from other folks.

But I think it makes sense to limit the warnings to talk about only HTTP.jl pre-v1.0 and Downloads.jl pre-julia-1.8 since there aren't open issues as far as I know w/ the newest versions.

@ericphanson
Copy link
Member

BTW I think it would be great to have some kind of open source example application demonstrating high throughput to s3 (or between ec2 and s3) w/ different object sizes and backends which could also be used as a smoketest here to check for concurrency issues/regressions/which versions actually work correctly, as well as to show known-good patterns for doing that through the julia ecosystem.

Copy link
Member

@mattBrzezinski mattBrzezinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 13, 2023

Canceled.

@mattBrzezinski mattBrzezinski merged commit 183a579 into JuliaCloud:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants