Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statuses: write permission to GH token for docdeploy #379

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

fredrikekre
Copy link
Member

This is needed to post the GitHub status with preview links, see Documenter.jl documentation.

This is needed to post the GitHub status with preview links, see [Documenter.jl documentation](https://documenter.juliadocs.org/dev/man/hosting/#GitHub-Actions).
Copy link
Collaborator

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(apologies for the broken CI here - #370)

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #379 (37e8d15) into master (0de5d85) will decrease coverage by 25.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #379       +/-   ##
===========================================
- Coverage   95.03%   69.44%   -25.59%     
===========================================
  Files          20       20               
  Lines         644      540      -104     
===========================================
- Hits          612      375      -237     
- Misses         32      165      +133     
Impacted Files Coverage Δ
src/plugins/develop.jl 0.00% <0.00%> (-100.00%) ⬇️
src/plugins/register.jl 0.00% <0.00%> (-100.00%) ⬇️
src/plugins/coverage.jl 0.00% <0.00%> (-90.91%) ⬇️
src/plugins/ci.jl 15.49% <0.00%> (-81.98%) ⬇️
src/plugins/citation.jl 0.00% <0.00%> (-80.00%) ⬇️
src/plugins/license.jl 33.33% <0.00%> (-57.15%) ⬇️
src/plugins/compat_helper.jl 50.00% <0.00%> (-50.00%) ⬇️
src/plugins/badges.jl 57.14% <0.00%> (-42.86%) ⬇️
src/plugins/tagbot.jl 62.50% <0.00%> (-37.50%) ⬇️
src/plugins/src_dir.jl 75.00% <0.00%> (-25.00%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nickrobinson251
Copy link
Collaborator

Oh but this failure is real: https://github.com/JuliaCI/PkgTemplates.jl/actions/runs/3949873044/jobs/6761646319

We just need to update the test/fixtures/ files to what we expect

I think that means changing the two reference tests that have GHA CI and use Documenter i.e.

Also, do we need to change this repo's own documenter setup in anyway (i.e. https://github.com/JuliaCI/PkgTemplates.jl/blob/0de5d855e050d93169f8661a13b3a53a8cb2b283/.github/workflows/CI.yml)?

@fredrikekre
Copy link
Member Author

Also, do we need to change this repo's own documenter setup in anyway

Not necessarily. I believe by default the token has all permissions, so since it is not limited to contents: write it also can post statuses.

@nickrobinson251 nickrobinson251 merged commit 305aa36 into master Jan 18, 2023
@nickrobinson251 nickrobinson251 deleted the fe/statuses branch January 18, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants