Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing interactive menu broken in Juila1.8 #370

Open
BaileyBox opened this issue Oct 19, 2022 · 1 comment
Open

Testing interactive menu broken in Juila1.8 #370

BaileyBox opened this issue Oct 19, 2022 · 1 comment

Comments

@BaileyBox
Copy link

BaileyBox commented Oct 19, 2022

I believe some changes were made to Pkg.jl, such stdin is no longer the global stdin, but instead an IOStream. Here's a link to that PR.

The testset that is breaking is SimulatedInputs

This makes it such that calling stdin.buffer results in:

Got exception outside of @test
  type IOStream has no field buffer

I tried just removing .buffer from stdin, but then ran into this error:

Default template: Error During Test at /Users/baileybox/Documents/Projects/JuliaProjects/1.8/dev/PkgTemplates/test/interactive.jl:84
  Test threw exception
  Expression: Template(; interactive = true) == Template(; user = USER)
  EOFError: read end of file

# Along with

Warning: TerminalMenus: Unable to enter raw mode:
│   exception =
│    MethodError: no method matching check_open(::IOStream)
│    Closest candidates are:check_open(::Union{Base.LibuvServer, Base.LibuvStream}) at stream.jl:386check_open(::Base.Filesystem.File) at filesystem.jl:114

The fix for this would be to setup our own type of stdin, or changing how we call interactive from with the tests.

@oxinabox
Copy link
Collaborator

oxinabox commented Feb 8, 2023

As a short term work around maybe we can restrict the interactive tests to only run on 1.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants