Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using GitLab CI extends #140

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

omus
Copy link
Contributor

@omus omus commented Feb 14, 2020

Use GitLab CI's extends instead of YAML anchors. The extends is a bit more flexible and the syntax is a bit cleaner.

Note this change will conflict with #131.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #140 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          17       17           
  Lines         329      329           
=======================================
  Hits          308      308           
  Misses         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba14f89...7d3a53a. Read the comment docs.

@christopher-dG
Copy link
Member

Needs a rebase but looks good to me, provided you've tested that this actually works properly with GitLab!

@omus omus force-pushed the cv/gitlab-extends branch from 53e8460 to 7d3a53a Compare February 24, 2020 17:44
@omus
Copy link
Contributor Author

omus commented Feb 24, 2020

Rebased and I've validated that the change works with GitLab CI. I'll note that extends requires GitLab 11.3 which we may want to mention somewhere. Current version is 12.8

@christopher-dG christopher-dG merged commit 71fc3de into master Feb 25, 2020
@christopher-dG christopher-dG deleted the cv/gitlab-extends branch February 25, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants