-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use literal block style for multi-line YAML #131
Conversation
Thanks for the bump, I'll get to this on the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good idea. I think the GitHubActions
plugin could benefit from this as well.
Also, the test files will need to be updated (you can include("test/runtests.jl")
and accept the prompts to update the files).
Allows for Julia code to not require the use of semi-colon which is matches how most users will write Julia code. An additional benefit is that it allows for use of single line comments.
383b595
to
e258aac
Compare
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 92.04% 93.31% +1.26%
==========================================
Files 17 17
Lines 327 329 +2
==========================================
+ Hits 301 307 +6
+ Misses 26 22 -4
Continue to review full report at Codecov.
|
It would be good to document this in a CONTRIBUTING.md file |
@@ -12,7 +12,7 @@ julia: | |||
before_script: | |||
- git config --global user.name Tester | |||
- git config --global user.email [email protected] | |||
script: travis_wait julia --project -e 'using Pkg; Pkg.test(; coverage=true)' | |||
script: travis_wait julia --project -e 'using Pkg; Pkg.test(coverage=true)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally like using semicolons for all keyword arguments but these changes are fine with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tend to use semicolons. In this particular case it seems worthwhile to be a bit more terse
Allows for Julia code to not require the use of semi-colon which is matches how most users will write Julia code. An additional benefit is that it allows for use of single line comments.