Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coveralls submission, and re-enable Coveralls submission from CI #315

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jun 9, 2021

Fixes #314
Closes #310
Closes #313

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #315 (fe023c7) into master (e0655f8) will increase coverage by 0.51%.
The diff coverage is 100.00%.

❗ Current head fe023c7 differs from pull request most recent head d108113. Consider uploading reports for the commit d108113 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   90.25%   90.76%   +0.51%     
==========================================
  Files           2        2              
  Lines         195      195              
==========================================
+ Hits          176      177       +1     
+ Misses         19       18       -1     
Impacted Files Coverage Δ
src/coveralls.jl 94.17% <100.00%> (-1.95%) ⬇️
src/codecovio.jl 86.95% <0.00%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0655f8...d108113. Read the comment docs.

@DilumAluthge DilumAluthge changed the title Fix Coveralls Fix Coveralls submission, and re-enable Coveralls submission from CI Jun 9, 2021
src/coveralls.jl Outdated Show resolved Hide resolved
src/coveralls.jl Outdated Show resolved Hide resolved
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking that down!

src/coveralls.jl Outdated Show resolved Hide resolved
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Jun 9, 2021

Your tip to look at lemurheavy/coveralls-public#1527 was spot-on. The issue was indeed that our JSON was not typed the way that Coveralls expected it to be typed.

@DilumAluthge DilumAluthge merged commit aa01a30 into master Jun 9, 2021
@DilumAluthge DilumAluthge deleted the dpa/fix-coveralls branch June 9, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging the Coveralls errors
2 participants