-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Coveralls submission, and re-enable Coveralls submission from CI #315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 90.25% 90.76% +0.51%
==========================================
Files 2 2
Lines 195 195
==========================================
+ Hits 176 177 +1
+ Misses 19 18 -1
Continue to review full report at Codecov.
|
906c54a
to
c9eb6fa
Compare
ef9f02a
to
b476fe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking that down!
Your tip to look at lemurheavy/coveralls-public#1527 was spot-on. The issue was indeed that our JSON was not typed the way that Coveralls expected it to be typed. |
Co-authored-by: Jameson Nash <[email protected]>
fe023c7
to
d108113
Compare
Fixes #314
Closes #310
Closes #313