Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging the Coveralls errors #314

Closed
DilumAluthge opened this issue Jun 9, 2021 · 3 comments · Fixed by #315
Closed

Debugging the Coveralls errors #314

DilumAluthge opened this issue Jun 9, 2021 · 3 comments · Fixed by #315

Comments

@DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member Author

@vtjnash Take a look at these lines:

"source_digest" => digest(MD_MD5, fc.source, "secret"),

If I understand correctly, MbedTLS.digest returns a Vector{UInt8}.

However, the Coveralls API documentation (https://docs.coveralls.io/api-introduction) has this "example of what a source file would look like as JSON":

{
  "name":     "lib/example.rb",
  "source_digest":   "1eb14b3a053f951ca925f2fd4d633eeb",
  "coverage": [null, 1, null]
}

If I understand correctly, this means that source_digest needs to be a string.

Is there a way for me to convert the output of MbedTLS.digest into a string in a way that is compatible with what the Coveralls API expects?

@DilumAluthge
Copy link
Member Author

I'll try bytes2hex and see if Coveralls accepts that.

@vtjnash
Copy link
Member

vtjnash commented Jun 9, 2021

Seems like a good observation and fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants