Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for zero-dimensional linalg #216

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

kshyatt
Copy link
Collaborator

@kshyatt kshyatt commented Jun 3, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 88.004% when pulling 10b872c on kshyatt:ksh/testzerodim into f7e6eb6 on JuliaArrays:master.

@codecov-io
Copy link

Codecov Report

Merging #216 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #216      +/-   ##
========================================
+ Coverage   87.77%    88%   +0.22%     
========================================
  Files          31     31              
  Lines        2184   2184              
========================================
+ Hits         1917   1922       +5     
+ Misses        267    262       -5
Impacted Files Coverage Δ
src/linalg.jl 97.02% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e6eb6...10b872c. Read the comment docs.

@andyferris andyferris merged commit f2f6fac into JuliaArrays:master Jun 4, 2017
@kshyatt kshyatt deleted the ksh/testzerodim branch August 3, 2017 22:58
oschulz pushed a commit to oschulz/StaticArrays.jl that referenced this pull request Apr 4, 2023
This introduces the internal utility `maybe_convert_elt` used to
convert values to the element type of the StructArray before
assignment. This fixes errors that are caused by assigning a value
that does not have the same fields as the struct but which can be
converted to such a type (e.g., `T<:Real` -> `Complex{T}`). Rather
than calling `convert` directly, `maybe_convert_elt` can be
specialized for particular types, like LazyRow, which should not be
converted.

Fixes JuliaArrays#131
Fixes JuliaArrays#216
Closes JuliaArrays#184

Co-authored-by: Gustavo Goretkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants