Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVector + Vector: Julia 0.5 vs 0.6 #131

Closed
krcools opened this issue Mar 31, 2017 · 4 comments
Closed

SVector + Vector: Julia 0.5 vs 0.6 #131

krcools opened this issue Mar 31, 2017 · 4 comments

Comments

@krcools
Copy link

krcools commented Mar 31, 2017

Not sure if this is by design or not but I noticed that on julia-0.5 a SVector added to an Array results in an SVector, wheras on julia-0.6 it results in an Array.
@c42f
Copy link
Member

c42f commented Apr 1, 2017

Yes, these were dropped in #121 (see the description), but perhaps they should be reimplemented.

It should be very easy to implement the map-like operations again, I'll have a go at that first.

@andyferris
Copy link
Member

I support reimplementing these.

@c42f
Copy link
Member

c42f commented Apr 4, 2017

Started in #136

c42f added a commit to JuliaGeometry/CoordinateTransformations.jl that referenced this issue Apr 11, 2017
@c42f
Fix test for StaticArrays-0.4.0 quirk
2f355b4 
Make test slightly less strict to work around
JuliaArrays/StaticArrays.jl#131
@c42f c42f mentioned this issue Apr 11, 2017
Merged
@c42f
Copy link
Member

c42f commented Apr 11, 2017

Fixed in #136 (see also #140)

@c42f c42f closed this as completed Apr 11, 2017
@c42f c42f mentioned this issue Apr 18, 2017
Closed
oschulz pushed a commit to oschulz/StaticArrays.jl that referenced this issue Apr 4, 2023
@timholy @goretkin
setindex!: convert to eltype (fixes JuliaArrays#216) (JuliaArrays#227)
9d357fc 
This introduces the internal utility `maybe_convert_elt` used to
convert values to the element type of the StructArray before
assignment. This fixes errors that are caused by assigning a value
that does not have the same fields as the struct but which can be
converted to such a type (e.g., `T<:Real` -> `Complex{T}`). Rather
than calling `convert` directly, `maybe_convert_elt` can be
specialized for particular types, like LazyRow, which should not be
converted.

Fixes JuliaArrays#131
Fixes JuliaArrays#216
Closes JuliaArrays#184

Co-authored-by: Gustavo Goretkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@c42f @andyferris @krcools