Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractArray constructor for OneElement #261

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 2, 2023

On master

julia> convert(AbstractArray{Float64}, OneElement(2, 4))
4-element Vector{Float64}:
 0.0
 1.0
 0.0
 0.0

This PR

julia> convert(AbstractArray{Float64}, OneElement(2, 4))
4-element OneElement{Float64, 1, Tuple{Int64}, Tuple{Base.OneTo{Int64}}}:
   
 1.0
   
   

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #261 (e0713bb) into master (91f9f6f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           5        5           
  Lines         771      772    +1     
=======================================
+ Hits          769      770    +1     
  Misses          2        2           
Impacted Files Coverage Δ
src/oneelement.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty
Copy link
Member

I think this counts as a "new feature" and warrants a v1.2 tag?

@dlfivefifty
Copy link
Member

I'll merge your other PRs after this one and they can all go in v1.2

@dlfivefifty dlfivefifty merged commit dab9cdf into JuliaArrays:master Jun 5, 2023
@jishnub jishnub deleted the oneelconverteltype branch June 5, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants