Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use values in iszero #635

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 5, 2024

This should be more correct, especially if SumSpaces are involved

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (023b1a4) 75.20% compared to head (63e9471) 43.64%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Operators/Operator.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #635       +/-   ##
===========================================
- Coverage   75.20%   43.64%   -31.56%     
===========================================
  Files          79       79               
  Lines        8445     8344      -101     
===========================================
- Hits         6351     3642     -2709     
- Misses       2094     4702     +2608     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 77cd9f1 into JuliaApproximation:master Feb 5, 2024
12 of 14 checks passed
@jishnub jishnub deleted the iszerovalues branch February 5, 2024 12:17
@jishnub jishnub mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant