Use values in iszero (#635)

* Use values in iszero * Special case empty coeff vectors * Check for zero coefficients first * Fix typo
JuliaApproximation · Feb 5, 2024 · 77cd9f1 · 77cd9f1
1 parent 9e06124
commit 77cd9f1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Fun.jl b/src/Fun.jl
@@ -773,7 +773,7 @@ isapprox(g::Number, f::Fun; kw...) = isapprox(g*ones(space(f)), f; kw...)
 isreal(f::Fun{<:RealSpace,<:Real}) = true
 isreal(f::Fun) = false
 
-iszero(f::Fun)    = all(iszero,f.coefficients)
+iszero(f::Fun)    = all(iszero, coefficients(f)) || all(iszero, values(f))
 
 # Deliberately not named isconst or isconstant to avoid conflicts with Base or DomainSets
 isconstantfun(f::Fun) = iszero(f - first(f))

diff --git a/test/SpacesTest.jl b/test/SpacesTest.jl
@@ -208,6 +208,11 @@ using Test
             F = Fun{typeof(PointSpace(1:3)), Float32}
             @test ApproxFunBase.cfstype(F) == Float32
         end
+
+        @testset "isconstantfun" begin
+            f = Fun(PointSpace(1:4), ones(4))
+            @test ApproxFunBase.isconstantfun(f)
+        end
     end
 
     @testset "DiracSpace" begin