Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): reject after connecting to WiFi with SSID-prefix #183

Merged

Conversation

ca057
Copy link
Contributor

@ca057 ca057 commented May 20, 2021

Closes #182

I tested the proposed idea (similar to what is done when connecting to a protected network with the full SSID, verify the connection after connecting only with a prefix provided) I had from looking at the source code and could confirm that this indeed fixes the issue of connectToProtectedSSIDPrefix not rejecting when the connection was not successful. The system alert does still appear, but the method properly rejects.

I tested this change with an app on my iPhone with iOS 14.4. Are there any additional tests/steps I should perform?

Thanks for your support!

Similar to what is done when connecting to a protected network with the full SSID, verify the connection after connecting only with a prefix provided. Closes JuanSeBestia#182
@Rapsssito
Copy link
Collaborator

@ca057, I am not able to test this PR in my local workstation. Have you test both promise rejection and resolution?

@ca057
Copy link
Contributor Author

ca057 commented May 23, 2021

@ca057, I am not able to test this PR in my local workstation. Have you test both promise rejection and resolution?

Hey, yes, I tested both paths. But I’m having trouble to connect only with the prefix. The connection is only working when I pass the full Wi-Fi name (e.g. when it’s called abc-def to connectToProtectedSSIDPrefix):

  • connectToProtectedSSIDPrefix('abc') --> is not able to connect, but properly rejects with the change
  • connectToProtectedSSIDPrefix('abc-def') --> is able to connect and resolves as expected (I have the same behaviour without my fix)

@Rapsssito
Copy link
Collaborator

LGTM!

@Rapsssito Rapsssito merged commit f255caa into JuanSeBestia:master May 26, 2021
JuanSeBestia pushed a commit that referenced this pull request May 26, 2021
## [4.3.8](v4.3.7...v4.3.8) (2021-05-26)

### Bug Fixes

* **iOS:** Reject after not connecting to WiFi with SSID-prefix ([#183](#183)) ([f255caa](f255caa)), closes [#182](#182)
@JuanSeBestia
Copy link
Owner

🎉 This PR is included in version 4.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ca057 ca057 deleted the fix/reject-when-connecting-with-prefix branch May 27, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] connectToProtectedSSIDPrefix doesn’t reject when WiFi couldn’t be joined
3 participants