Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] connectToProtectedSSIDPrefix doesn’t reject when WiFi couldn’t be joined #182

Closed
ca057 opened this issue May 20, 2021 · 1 comment · Fixed by #183
Closed

[iOS] connectToProtectedSSIDPrefix doesn’t reject when WiFi couldn’t be joined #182

ca057 opened this issue May 20, 2021 · 1 comment · Fixed by #183
Labels
bug Something isn't working iOS released

Comments

@ca057
Copy link
Contributor

ca057 commented May 20, 2021

Hey, thanks for your library!

I’m currently trying to join a network where I just know the beginning, but not the full SSID. Even though I can see the WiFi when checking the list of networks in the settings, my app is not able to connect to the access point by supplying it with only the prefix (when using the full name during development, it works). Is there something additional I should do before trying the prefix?

The main issue I’m facing is that when I’m calling connectToProtectedSSIDPrefix with the SSID-prefix and it fails to connect, the method doesn’t reject but fulfills and I’m only getting a system alert saying ‘Unable to join the network “...”’.

Is this intended? Shouldn’t it reject as well when joining the network wasn’t successful?

Could it be that the else-case needs to look similar to the one from connectToProtectedSSDID?

I’m happy to assist with debugging/testing or fix it myself, if my assumption is correct.

These are the parameters of all libraries/phones:
ca057 added a commit to ca057/react-native-wifi-reborn that referenced this issue May 20, 2021
@ca057
fix(iOS): reject after connecting to WiFi with SSID-prefix
5876a9e 
Similar to what is done when connecting to a protected network with the full SSID, verify the connection after connecting only with a prefix provided. Closes JuanSeBestia#182
@ca057 ca057 mentioned this issue May 20, 2021
Merged
@Rapsssito Rapsssito added bug Something isn't working iOS labels May 22, 2021
Rapsssito pushed a commit that referenced this issue May 26, 2021
@ca057
fix(iOS): Reject after not connecting to WiFi with SSID-prefix (#183)
f255caa 
Similar to what is done when connecting to a protected network with the full SSID, verify the connection after connecting only with a prefix provided. Closes #182
JuanSeBestia pushed a commit that referenced this issue May 26, 2021
@semantic-release-bot
chore(release): 4.3.8 [skip ci]
a5aafaa 
## [4.3.8](v4.3.7...v4.3.8) (2021-05-26)

### Bug Fixes

* **iOS:** Reject after not connecting to WiFi with SSID-prefix ([#183](#183)) ([f255caa](f255caa)), closes [#182](#182)
@JuanSeBestia
Copy link
Owner

🎉 This issue has been resolved in version 4.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working iOS released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iOS): reject after connecting to WiFi with SSID-prefix ca057/react-native-wifi-reborn
3 participants
@JuanSeBestia @ca057 @Rapsssito