Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make filter options collapsible #815

Conversation

maggienegm
Copy link
Contributor

PR Checklist

Overview

Previously, the filter options were always visible and could not be collapsed.

Now, the filter options can be collapsed, and the behavior is as follows:

  • By default, the filter options are visible when the site loads:
filter-options-visible
  • Users can toggle the filter options open and closed by clicking on the "Filter options by v" button:
filter-options-hidden
  • The filter options automatically close when a search is submitted:
search-results

Lastly, another fav emoji of mine: 🌱!

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidelift-me-up-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:14pm

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great start, thanks for sending this in!

It visually looks and feels great. Requesting changes to get it fully accessible.

Cute round cartoon penguin happily hopping on leaves

src/components/OptionsForm.module.css Show resolved Hide resolved
src/components/OptionsForm.tsx Outdated Show resolved Hide resolved
src/components/OptionsForm.tsx Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Nov 26, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-requested a review December 1, 2024 03:15
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Dec 1, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks, this is perfect!

@JoshuaKGoldberg JoshuaKGoldberg merged commit ed4cac4 into JoshuaKGoldberg:main Dec 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Make filter options collapsible
2 participants