generated from JoshuaKGoldberg/create-typescript-app
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make filter options collapsible #815
Merged
JoshuaKGoldberg
merged 5 commits into
JoshuaKGoldberg:main
from
maggienegm:feat-make-filter-options-collapsible
Dec 1, 2024
Merged
feat: make filter options collapsible #815
JoshuaKGoldberg
merged 5 commits into
JoshuaKGoldberg:main
from
maggienegm:feat-make-filter-options-collapsible
Dec 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoshuaKGoldberg
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JoshuaKGoldberg
added
the
status: waiting for author
Needs an action taken by the original poster
label
Nov 26, 2024
….com/maggienegm/tidelift-me-up-site into feat-make-filter-options-collapsible
github-actions
bot
removed
the
status: waiting for author
Needs an action taken by the original poster
label
Dec 1, 2024
JoshuaKGoldberg
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Thanks, this is perfect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Previously, the filter options were always visible and could not be collapsed.
Now, the filter options can be collapsed, and the behavior is as follows:
Lastly, another fav emoji of mine: 🌱!