Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Make filter options collapsible #5

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jun 27, 2023 · 0 comments · Fixed by #815
Closed
3 tasks done

🚀 Feature: Make filter options collapsible #5

JoshuaKGoldberg opened this issue Jun 27, 2023 · 0 comments · Fixed by #815
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, the (optionally, filter by:) options to filter on "Updated Since" and "Relationship to Project" are always visible & take up space:

Screenshot of the light mode submit form of the site with expanded, non-collapsible filter options

But when there are results in the page, it doesn't really make much sense to show those options. How about we make them collapsible, so that when you submit for results, they collapse automatically?

Vague prototype here that could absolutely be made to look better:

Screenshot of the submit form with options hidden and showing a 'V' collapso

Additional Info

This was originally suggested by @kathryngraysonnanz by our design pairing. I'd only not implemented it originally to save time in getting the v1 shipped.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Jun 27, 2023
@maggienegm maggienegm mentioned this issue Nov 26, 2024
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Dec 1, 2024
@maggienegm
feat: make filter options collapsible (#815)
ed4cac4 
<!-- 👋 Hi, thanks for sending a PR to tidelift-me-up-site! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #5 
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/tidelift-me-up-site/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/tidelift-me-up-site/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
Previously, the filter options were always visible and could not be
collapsed.

Now, the filter options can be collapsed, and the behavior is as
follows:
- By default, the filter options are visible when the site loads:
<img width="411" alt="filter-options-visible"
src="https://github.com/user-attachments/assets/a545f2e9-990a-4720-8e87-00c90d9e69e8">

- Users can toggle the filter options open and closed by clicking on the
"Filter options by v" button:
<img width="391" alt="filter-options-hidden"
src="https://github.com/user-attachments/assets/67f7f7b0-f247-4e08-ab7b-350331402ea3">

- The filter options automatically close when a search is submitted:
<img width="385" alt="search-results"
src="https://github.com/user-attachments/assets/dfc2060c-5f10-4870-85e2-46141378b263">

Lastly, another fav emoji of mine: 🌱!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make filter options collapsible maggienegm/tidelift-me-up-site
1 participant
@JoshuaKGoldberg