RPC maker/start returns 409 error if no coins #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamISZ
force-pushed
the
rpc-nocoins-maker
branch
from
96f6425 to
c20193e
Compare
|
bd33b6d is an edit (x2), because I forgot to specify |
Fixes #1120. As per the discussion in that issue, while we can only return 'processing started' by default, and the client must monitor progress/state to see if the maker service has connected successfully, nevertheless if the maker startup is immediately invalidated by the fact that the already-synced wallet does not contain confirmed coins, we can and should return an error message instead of a 202. This commit does that, adding to the spec a 409-No-Coins response type which indicates to the API client that the setup of the maker failed for this specific reason.
AdamISZ
force-pushed
the
rpc-nocoins-maker
branch
from
c20193e to
bd33b6d
Compare
|
Rationale for merging as per #1137 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1120. As per the discussion in that issue, while
we can only return 'processing started' by default, and
the client must monitor progress/state to see if the maker
service has connected successfully, nevertheless if the
maker startup is immediately invalidated by the fact that
the already-synced wallet does not contain confirmed coins,
we can and should return an error message instead of a 202.
This commit does that, adding to the spec a 409-No-Coins
response type which indicates to the API client that the
setup of the maker failed for this specific reason.