Add /taker/stop endpoint to RPC #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if a user has attempted a coinjoin with /taker/coinjoin but a problem occurs (such as an unresponsive maker), they are not able to abort the protocol but must wait until the taker_finished event is triggered. After this commit a GET request to the endpoint defined as /wallet/walletname/taker/stop will force-stop the coinjoin attempt (similar to quitting the script in CLI). This will reset the wallet daemon state to CJ_NOT_RUNNING.
|
Merging (the reason I am merging some of these RPC PRs with little waiting or review is so that people actually wanting to test the RPC can avoid these bugs, and that it has no cross-effects on the pre-existing non-RPC code; obviously it would be far better if some people actually reviewed them, but it's not currently in active use by users so not really dangerous). |
This was referenced Jan 10, 2022
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if a user has attempted
a coinjoin with /taker/coinjoin but a problem
occurs (such as an unresponsive maker), they
are not able to abort the protocol but must wait
until the taker_finished event is triggered.
After this commit a GET request to the endpoint
defined as /wallet/walletname/taker/stop will
force-stop the coinjoin attempt (similar to
quitting the script in CLI). This will reset the
wallet daemon state to CJ_NOT_RUNNING.