Create network_port_object.py #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the definition for the NetworkPortObject. * I had a question on the data type on line #112 The optional properties for this are not always optional depending on other properties defined. How should that be handled?
|
There is no generalized framework for validating objects, i.e., checking to make sure that all required properties are defined and checking for proper combinations of optional ones. For now if a property has an 'O' in the Conformance Code column that is enough. There are some additional unsigned properties with value restrictions (like Max_Master is 0..127, Priority_For_Writing is 1..16, AccessThreatLevel is 0..100) and it would be nice to handle these consistently, I think this is going in the right direction. There are choices and sequences that are context encoded (the number in brackets in the ASN.1 notation) that need to be added to the new things in the base types. |
added property number comments from standard.
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the definition for the NetworkPortObject.
The optional properties for this are not always optional depending on other properties defined. How should that be handled?